Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: colorize output #5716

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ci: colorize output #5716

merged 1 commit into from
Sep 19, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Sep 18, 2024 •
edited
Loading

Proposed Commit Message

ci: colorize output

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb marked this pull request as ready for review September 18, 2024 22:05
TheRealFalcon
TheRealFalcon approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever parse or otherwise deal with the raw logs, we'll need to undo this, but since we don't currently, this LGTM.

<tried to paste a raw logs link showing all of the annoying color codes inline, but link expired or something>

@holmanb holmanb merged commit 9d0fc5a into canonical:main Sep 19, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holmanb @TheRealFalcon